fullstorydev / hauser

Service for moving your Fullstory export files to a data warehouse
MIT License
49 stars 23 forks source link

Add note for go requirement #7

Closed sanjaybv closed 6 years ago

sanjaybv commented 6 years ago

Apparently, users are required to use go 1.7 or higher because "context" package is unavailable in versions < 1.7

sanjaybv commented 6 years ago

@jameremo Can you think of other requirements that would be good to add? if there are more, it's probably better to have them in their own sub-heading.

jhump commented 6 years ago

I think you could also just change warehouse/bigquery.go and warehouse/redshift.go to import "golang.org/x/net/context" instead of "context". Not sure whether we want to support Go 1.6 or not, but it seems like all of the deps (including the bigquery and redshift client libraries) support it.

jameremo commented 6 years ago

Everything besides go and git should be included in the vendor libraries that are checked into the repo. I don't think we need to put something in there about needing git, that seems like something every engineer should understand?

I don't have a strong opinion on supporting older versions of go, but per their official release page:

Each major Go release is supported until there are two newer major releases. For example, Go 1.8 is supported until Go 1.10 is released, and Go 1.9 is supported until Go 1.11 is released.

So I think it's reasonable not to spend a lot of effort caring about 1.6 at this point.

https://golang.org/doc/devel/release.html

jhump commented 6 years ago

So I think it's reasonable not to spend a lot of effort caring about 1.6 at this point.

Fair enough. I think a lot of libraries still try to support it (including grpc and protobuf) because of Google App Engine. Its support for Go 1.8 just went GA a few months ago, so it is likely that not everyone has moved up from 1.6. But since hauser is an app, not a library, it makes sense to not bother with the far-reaching support.

jhump commented 6 years ago

Sorry - didn't mean to close this. Clicked the wrong button :/

jameremo commented 6 years ago

Ah, that makes sense, thanks. I did not realize App Engine Go support had such a lag.

sanjaybv commented 6 years ago

I'm not going to change the imports to support go 1.6.