Allow S3 Only to use Sync Table

fullstorydev / hauser

Service for moving your Fullstory export files to a data warehouse

MIT License

48 stars 23 forks source link

Allow S3 Only to use Sync Table #79

Closed clettieri closed 4 years ago

clettieri commented 4 years ago

Our use case had us only needing to ingest directly to S3. In order to take advantage of hauser's Sync table feature, we needed to update this function to call SaveSyncPoints() when S3Only is set in the config.

A quick little hack here but this allows anyone who wants to use ONLY S3 to take advantage of the SyncTable. This update will still preserve the intended functionality for Redshift warehouse users.

Hope others can find this useful.

patrick-fs commented 4 years ago

Hey @clettieri, thanks for your PR! We'll take a look at it.

Your contribution is much appreciated!

camphillips22 commented 4 years ago

Hey @clettieri, I realize this is a bit old, but I recently merged #89 which enables this flow by saving a "sync file" to the same S3 bucket. I'm going to go ahead and close this PR since it's no longer necessary.