fullstorydev / solr-bench

Solr benchmarking and load testing harness
Apache License 2.0
17 stars 10 forks source link

Bypass git cloning and meta generation if no repo is provided on "external" mode #37

Closed patsonluk closed 1 year ago

patsonluk commented 1 year ago

Description

For the "external" mode, technically there's no need to provide any repository info for the benchmarking itself. Only if the user want to generate the meta file (git commit info) would "external" mode actually need to clone and do various git commands.

The meta file is used to describe the test run and fed as input of the graphing script. However in some cases, it's quicker and easier if the caller has other ways to generate such meta file. (or if the caller does not care about the meta file/graph)

In such scenario ("repositories" not provided in the config), we should simply bypass git cloning and meta file generation

@chatman please lemme know if this makes sense. The git diff is a bit weird, the changes should only be adding several "if "respositories" is defined in config" check 😓