search

fullstorydev / solr-bench

Solr benchmarking and load testing harness
Apache License 2.0
17 stars 10 forks source link

Do not proceed with the current task and its dependent task if running into exceptions #43

Closed patsonluk closed 1 year ago

patsonluk commented 1 year ago

Description

It's found during testing that even if indexing failed, the restart and query tasks would carry on, the result data themselves are not entirely clear that something bad has happened.

Restart failure also do not really interrupt the workflow and it's really easy to be mistaken that everything went smoothly

Solution

There are 2 main changes with this PR:

  1. If a task failed with exception, it should interrupt itself as well as all the "waitFor" (dependent) tasks. The interruption of those tasks with warning message and missing result metrics make it obviously that something has gone wrong. Other tasks that have no dependency ("waitFor") or such task would still proceed as normal
  2. Restart script failure should be treated as an exception and the corresponding task should be flagged as failed.

@chatman since this is a pretty big change to the workflow behavior, would love to hear your thoughts. Many thanks!

chatman commented 1 year ago

LGTM... This is very useful. THanks a lot!