fullwall / Citizens

An NPC plugin for bukkit.
Other
35 stars 7 forks source link

Trader: Endless items generation #115

Closed legal-xx closed 13 years ago

legal-xx commented 13 years ago

When you are using the Trader's inventory you can try to move the some item here. So, plugin dosn't allow to do it and return item back to position.

But if you try quickly move some item away from a Trader's inventory or your own inventory - it will be successed! Item wll be dropped away but plugin return back an item to the inventory too. In the result, item stays into inventory, but it was dublicated to the drop. So, you take the drop free. Do it again ang again and this way you can generate any value of items placed in trader's inventory or your own inventory. And ofcource, you have't pay anything, because transaction was not complited

It seems like cheating and crashes an economic balance. Please, solve this problem, don't let any player to use this bug. Citizens version: the latest from this git. Minecraft version: 1.6.6

P.s. May be you should to add different checking or something else... Thank you.

legal-xx commented 13 years ago

Please, leave your comment! Did somebody detect this bug on his own server?

It is impossible to use the Trader when this bug exists.

aPunch commented 13 years ago

We no longer support MC Beta 1.6.6. Are you sure this bug still exists with Citizens 1.0.9b and MC Beta 1.7.3?

Hazzie commented 13 years ago

Confirmed, bug still exists on all latest builds. Bukkit RB #1000 + Citizens 1.0.9c

fullwall commented 13 years ago

Ugh, this issue exists because inventory events are lacking. We need them to properly fix this issue.

legal-xx commented 13 years ago

Bukkit RB #1000 + Citizens 1.0.9d Bug still exist...

fullwall commented 13 years ago

Waiting on bukkit here.