search

fulmicoton / fattable

Javascript Library to create scrollable table with infinite rows and columns.
MIT License
482 stars 39 forks source link

TableView cleanup ScrollBarProxy #17

Closed encodedstephen closed 9 years ago

encodedstephen commented 10 years ago

I believe that the ScrollBarProxy cleanup doesn't work for the cleanup method in TableView (line 546 of fattable.coffee):

cleanUp: ->
    # be nice rewind !
    @eventRegister.unbindAll()
    @ScrollBarProxy?.onScroll = null

After reading over the code, I believe that you were trying to do: 

cleanUp: ->
    # be nice rewind !
    @eventRegister.unbindAll()
    @scroll?.onScroll = null
fulmicoton commented 10 years ago

Yes you are right. Thank you very much. I'll fix that very very soon.

PAEz commented 9 years ago

really? ;)

fulmicoton commented 9 years ago

No I haven't >.< Well I accept pull request :)

fulmicoton commented 9 years ago

Fixed in 833904c0ecff3b2ccf17c4a8e03b053b0b74a164