fulmicoton / fattable

Javascript Library to create scrollable table with infinite rows and columns.
MIT License
482 stars 39 forks source link

allows scrolling past bottom #5

Closed max-mapper closed 10 years ago

max-mapper commented 10 years ago

e.g. screen shot 2014-02-23 at 5 34 14 pm

also

screen shot 2014-02-23 at 5 34 20 pm

shouldn't it stop at the bottom?

fulmicoton commented 10 years ago

Might be related to a comment on reddit :

The limit is different in each browser. I think IE has the smallest (across all versions). As I said, this limit applies to the maximum scrollTop, so you can't just chain together a series of shorter elements. I tried that method and failed. Maybe you will have better luck? You can partially solve this problem by detecting the max height and snapping to it, then calculating the scroll position and showing the rows based on the percentage the user has scrolled, but this leads to pigeon-holing and some rows become impossible to view because scrolling even 1px jumps past more records than can be shown on screen. I'm not sure how SlickGrid solved it (or if they even did solve it). Good luck.

fulmicoton commented 10 years ago

Confirmed its due to this issue. I halved the number of row in the demo, and for the moment it can be considered as a limitation of the library.

If anyone needs to display more rows, let me know, there are a couple of ways to fix this.