search

fulup-bzh / GeoGate

GeoGate is an opensource tracking GPS/AIS framework to implement GTS applications.
Apache License 2.0
74 stars 39 forks source link

Ais: MMSI as String #13

Closed afischerdev closed 7 years ago

afischerdev commented 7 years ago

In ggencoder lib the mmsi value comes as integer. The ais definition says it is a 9-digit ID. E.g. the base stations has 2 leading zeros. I forgot it when I made the changes.

I did a short check for Signal K. There is no problem with the type change. Are there other clients that come into trouble?

fulup-bzh commented 7 years ago

The change you made does not create trouble in GeoGate and http://sinagot.net/aisweb/mapview which is fine for me. Fell free to adresse the 9-digit-ID if ever this is important for you

afischerdev commented 7 years ago

Could you update this again please. npm publish needs permission Thanks

fulup-bzh commented 7 years ago

Done with gencoder@0.1.12

afischerdev commented 7 years ago

Great, thanks for that. But I didn't found the changes for string value - when I install ggencoder again. In git the change is noticed (encoder/lib/AisDecoder.js).

fulup-bzh commented 7 years ago

I refresh my git clone, and push back the encoder, hopefully not npm and git should be aligned.

afischerdev commented 7 years ago

Great, works perfect, thanks a lot.