fulup-bzh / GeoGate

GeoGate is an opensource tracking GPS/AIS framework to implement GTS applications.
Apache License 2.0
75 stars 39 forks source link

Ggencoder question about the new weather reports #50

Closed afischerdev closed 10 months ago

afischerdev commented 10 months ago

This is a call for all users of this library or this ggencoder package here:

The normal way in the library is to decode and prepare the value for output. Sample:

this.draught     = this.GetInt(294, 8 ) / 10.0;

The weather out now comes out as plain value:

this.airtemp       = parseInt(this.GetInt(154, 11, 1));

Is this ok for your or better to have a calculated value?

Please see also discussion here

KEGustafsson commented 10 months ago

Better would be outputting calculated value according to the specification.

E.g. for Temp 2's complement + divided by 10.

afischerdev commented 10 months ago

Values come out now precalculated.