Closed nktnet1 closed 1 week ago
Latest commit: 27ed96a750a4f0c8d09822819d1dea7fd75ce19b
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@nktnet1 is attempting to deploy a commit to the Fuma Team on Vercel.
A member of the Team first needs to authorize it.
It is expected, the usage in TSX files requires type property. It’s only added as a fallback for convenience in MDX files
Also the accordion component is mainly for displaying FAQs and additional sections, I prefer to have a copy button instead of changing hash when opening it, it’s more intuitive for people to quickly link to a section or answer
It is expected, the usage in TSX files requires type property. It’s only added as a fallback for convenience in MDX files
ah alright, understood. Should this be documented somewhere? Feel free to close this PR.
Also the accordion component is mainly for displaying FAQs and additional sections, I prefer to have a copy button instead of changing hash when opening it, it’s more intuitive for people to quickly link to a section or answer
That makes sense - I just thought it'll be good to support both. On our side, we have people (not many) getting confused by the hash not "working" when they selected a different accordion (e.g. they were initially sent a working link, tried to open a different accordion, then send the URL to someone else). For context, we use the accordion to show a weekly schedule of events.
I could also implement this client side though, so not an issue. Won't make a PR for it in that case. Thanks @fuma-nama.
Yeah it’s better to implement it on user land. I will improve the docs later
The documentation for accordian has the following as the example usage:
However, this resulted in the error:
Raw Error
``` Type '{ children: Element; }' is not assignable to type 'IntrinsicAttributes & ((OmitThis PR makes the accordion type optional. I've defined component
CustomProps
for now, and plan to add theupdateAnchor
option similar to the