Closed mayukojpn closed 5 years ago
@mayukojpn Thanks for your PR, and sorry for missing notification. I'll check and merge later!
Thanks for reviewing! This pull request is old and should update:
Never mind! PR is ready to merge :) This plugin supports only greater than 4.6 in its readme.txt and no need to define text domain and domain path.
Sorry, but I found that my add-ons uses domain wp-gianism
and changing domain breaks backward compatibility. So I can't merge this request.
Thanks.
Since WordPress 4.6, the Text Domain header is no longer required, however it have to match with plugin folder name. https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/#text-domains
This commit should be merged after importing your translation file to Translationg WordPress site: https://translate.wordpress.org/projects/wp-plugins/gianism/dev/ja/default/import-translations
Text Domain
andDomain Path
in plugin header.load_plugin_textdomain
and language files not to override community translation.