fumikito / gianism

WordPress Plugin to enable user to login with Social Account(Twitter, Facebook, Google etc.)
https://gianism.info/
25 stars 25 forks source link

Update internationalization. #81

Closed mayukojpn closed 5 years ago

mayukojpn commented 6 years ago

Since WordPress 4.6, the Text Domain header is no longer required, however it have to match with plugin folder name. https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/#text-domains

This commit should be merged after importing your translation file to Translationg WordPress site: https://translate.wordpress.org/projects/wp-plugins/gianism/dev/ja/default/import-translations

fumikito commented 6 years ago

@mayukojpn Thanks for your PR, and sorry for missing notification. I'll check and merge later!

mayukojpn commented 6 years ago

Thanks for reviewing! This pull request is old and should update:

Never mind! PR is ready to merge :) This plugin supports only greater than 4.6 in its readme.txt and no need to define text domain and domain path.

fumikito commented 5 years ago

Sorry, but I found that my add-ons uses domain wp-gianism and changing domain breaks backward compatibility. So I can't merge this request. Thanks.