auth: require base64 encoding for image file

fun-stack / terraform-aws-fun

Terraform module to provision AWS infrastructure for fun-stack

MIT License

5 stars 1 forks source link

auth: require base64 encoding for image file #28

Closed GRBurst closed 2 years ago

GRBurst commented 2 years ago

This PR is created for further discussion.

Instead of an image-encoding string, we require the image to be base64 encoded already. This allows uploading of local files using filebase64("myfilepath.png"). It further simplifies the module since we don't have to test weather it contains data or not.

Signed-off-by: GRBurst GRBurst@protonmail.com

cornerman commented 2 years ago

That makes more sense, I agree :)

cornerman commented 2 years ago

I would be happy to merge this already or is something missing?

GRBurst commented 2 years ago

go ahead

cornerman commented 2 years ago

Is released as version 0.10.0.