Notepad++ 8.4.2 and greater not showing icons

[vinsworldcom]

Describe the bug I'm testing the latest Notepad++ releases the earliest to exhibit this behavior is https://github.com/notepad-plus-plus/notepad-plus-plus/commit/33ab652395f9cf9b47dc9927f54d56c01f770951

You can see the issue reported there.

To Reproduce Steps to reproduce the behavior: Notepad++ should show icons in the lower pane of Explorer plugin, but with the commit artifact referenced above, it does not

Screenshots WORKING (older version of Notepad++):

NOT WORKING (using Notepad++ commit artifact from above):

Notice the lower pane in the second image shows no file icons.

Debug Info Notepad++ v8.4.2 (64-bit) Build time : Jun 5 2022 - 13:59:10 Path : C:\usr\bin\npp64\notepad++.exe Command Line : Admin mode : OFF Local Conf mode : ON Cloud Config : OFF OS Name : Windows 10 Enterprise (64-bit) OS Version : 21H2 OS Build : 19044.1706 Current ANSI codepage : 1252 Plugins : Explorer (1.8.2.17)

[vinsworldcom]

@funap , this may be resolved by a new pull request to Notepad++ - not yet accepted into master, but looks like it may.

Cheers.

[vinsworldcom]

This commit to Notepad++ master has resolved the issue.

Strange that the issue never did affect the "official" Explorer plugin (the one in Plugin Admin) - but I much prefer yours!

Cheers.

[funap]

@vinsworldcom , I am grateful that you were the first to recognize the problem, and we are glad that you did. Thank you for being the first to recognize the problem and taking action to resolve it.

[funap]

Strange that the issue never did affect the "official" Explorer plugin (the one in Plugin Admin)

There was also a small impact on the official plug-ins.

• Overlay icons for git, svn and etc.... are not displayed.
• [..] icon not displayed.
• File names are not underlined when files are open.

The official plugin was less affected because of the different way custom draw was implemented Thank you for finding this issue!