funap / npp-explorer-plugin

Explorer plugin for Notepad++ x64/x86
GNU General Public License v2.0
86 stars 10 forks source link

Little visual glitch or intended (dark themes)? #52

Closed klaus101 closed 1 year ago

klaus101 commented 1 year ago

Describe the bug I'm just trying this explorer plugin fork and would like to ask about three things. I really hope i don't bother! The first is a little visual glitch (at least at appears to me; but maybe it's intended or i'm in error): See image: the button representing opening a dropdown - upper right corner - and as well the splitter. A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior: 1.Set NPP dark mode; (within Settings > preferenes)

  1. Settings > Style Configurator -> try any dark theme
  2. Check the color of button (upper right corner) and splitter

Expected behavior Button and splitter colors should look consistent with the theme, Actually for me they don't (appear white). Is it inteneded? Or did i simply do an error?

Screenshots If applicable, add screenshots to help explain your problem. glitch

Debug Info Notepad++ v8.5 (64-bit) Build time : Mar 6 2023 - 02:18:13 Path : D:\Test\NPP\notepad++.exe Command Line : Admin mode : OFF Local Conf mode : ON Cloud Config : OFF OS Name : Windows 10 Home (64-bit) OS Version : 22H2 OS Build : 19045.2673 Current ANSI codepage : 1252 Plugins : Explorer (1.8.2.18) mimeTools (2.9) NppConverter (4.5) NppExport (0.4) NPPJSONViewer (2.0.4)



**Additional context**
The funap explorer plugin is the x64 version.  NPP is 8.5 x64 the portable version
funap commented 1 year ago

@klaus101 Thank you for contacting me! The dark mode is Notepad++ drawing the controls, but some of them seem to be incomplete. I will try to find out if it can be improved from the plugin side.

funap commented 1 year ago

This problem has been fixed in ver 1.8.2.20.

klaus101 commented 1 year ago

Thank you a lot funap for your fix! It's basically corrected now ... with the little caveat that the refresh button in the upper right corner is hard to recognize (i know such is a challenge with the dark themes). refresh_button

A part of the change is that - for the file list view - the selection color did change to a more usual and better looking blue. But the unfocused color now is white. I'd guess that had not been intended.

1.8.2.19 - left: selected focused right: selected unfocused: selecteed_unfocused_1 8 2-19

1.8.2.20 - left: selected focused right: selected unfocused: selecteed_unfocused_1 8 2-20

klaus101 commented 1 year ago

Oh ... and the file listview's hovering color (mouseover color) disappeared with the 1.8.20, that's not so good.

funap commented 1 year ago

Hi @klaus101 Thanks for your report!! I was checking on Windows 11. I thought it was displaying well.

win11_listview_dark

But, I understand that there is a problem when running on Windows 10. This Issue will remain Open until the issue is resolved.

klaus101 commented 1 year ago

Differences here between win10 and win11 ... - oh no :-(

ListView, Win 10 / 1.8.2.19 for me looked quite good. win10x64_1 8 2 19

With 1.8.2.20 the selecton color appeared a bit nicer and a oftenly chosen color, but the "unfocusing" and "hovering" behaviour is a caveat. Strange that is is so different between win10 and 11. win10x64_1 8 2 20

funap commented 1 year ago

@klaus101 Thank you very much! I really understand! :)

I will fix to be independent of OS version.

klaus101 commented 1 year ago

Hi funap, thank yoo! This OS differerence is a bad surprise i guess.

Btw for to avoid confusion: just noticed that my NPP theme file used here was not "DarkModeDefault", sorry. Repeated the test with "DarkModeDfault", but bvasically it's the same. Just as expected.

funap commented 1 year ago

v1.8.2.21 has been released. List view changes in 1.8.2.20 have been revert.

klaus101 commented 1 year ago

Ok, on Win10 for the listview (and treeview) it's back to the appearances as of the 1.8.2.19, which is qhite good imo.

The two little glitches mentioned in the OP (concerning refresh button, and splitter) are fixed. The refresh button is a bit hard to recognize, but ok, it's not really a problem. So i think this can be closed .... Thank you very much funap for your efforts!

funap commented 1 year ago

You’re very welcome!