search

funbox / smppex

✉️ SMPP 3.4 protocol and framework implementation in Elixir
MIT License
106 stars 34 forks source link

Add socket_opts options to ESME #74

Closed IceDragon200 closed 4 years ago

IceDragon200 commented 4 years ago

I needed to make some changes to the ESME's socket configuration, specifically overriding the supported SSL ciphers (erlang changed the defaults recently and we needed the old ones)

This PR adds the socket_opts keyword pair to the ESME opts allowing users to add additional socket options to the connection, the specific options supported are purposely omitted from the docs as they vary on the transport.

We've been running this for a few months now in production and has worked without issue.

I've also corrected the misleading transport_opts in the ESME test (as it wasn't implemented in the module to begin with)

savonarola commented 4 years ago

Hello! Thanks a lot for your contribution. There are few questions about the PR.