funcool / bide

A simple routing library for ClojureScript
BSD 2-Clause "Simplified" License
132 stars 20 forks source link

Define `-match` before using it #16

Closed dsteurer closed 6 years ago

dsteurer commented 6 years ago

Fix compiler warning (at least for shadow-cljs):

------ WARNING #1 --------------------------------------------------------------
 File: bide/core.cljs:155:42
--------------------------------------------------------------------------------
 152 |            :as opts}]
 153 |   (let [default (if (vector? default) default [default nil])]
 154 |     (letfn [(-on-navigate [event]
 155 |               (let [[name params query] (-match (.-token event))]
------------------------------------------------^-------------------------------
 Use of undeclared Var bide.core/-match
--------------------------------------------------------------------------------
 156 |                 (on-navigate name params query)))
 157 |             (-match [token]
 158 |               (let [result (match router token)]
 159 |                 (or result default)))
--------------------------------------------------------------------------------
niwinz commented 6 years ago

This is a shadow-cljs compiler issue, the default cljs compiler compiles it without any warning...