funcool / bide

A simple routing library for ClojureScript
BSD 2-Clause "Simplified" License
132 stars 20 forks source link

Warning when compiled with shadow-cljs: variable toString is undeclared #17

Closed theasp closed 6 years ago

theasp commented 6 years ago

The following warning is generated when compiling with shadow-cljs, though everything seems to work fine otherwise.

------ WARNING #1 --------------------------------------------------------------
 File: bide/impl/helpers.js:29:41

 variable toString is undeclared
--------------------------------------------------------------------------------

https://github.com/funcool/bide/blob/master/src/bide/impl/helpers.js#L29

niwinz commented 6 years ago

I can't handle any unexpected error with not official compilers, please reproduce that warning with standard compiler.

theasp commented 6 years ago

Hi @niwinz,

I believe that the warning is correct, toString is not defined. I think it should be using Object.prototype.toString.call()