search

funcool / bide

A simple routing library for ClojureScript
BSD 2-Clause "Simplified" License
131 stars 20 forks source link

ClojureScript 1.10.844 compatibility #26

Closed Juholei closed 3 years ago

Juholei commented 3 years ago

ClojureScript 1.10.844 contains a new version of the Closure library (https://clojurescript.org/news/2021-04-06-release), which has removed some previously deprecated functions. As such, bide does not work when using the newest ClojureScript release.

This pull request replaces goog.isDefAndNotNull, goog.isDef and goog.isString calls with the suggested replacements mentioned when these were deprecated in Closure (https://github.com/google/closure-library/commit/cdcf18cae23416b9fe7d8721fb7652187c40bed9).

niwinz commented 3 years ago

I will publish a release soon.

Juholei commented 3 years ago

Thank you!