funcool / buddy-auth

Authentication and Authorization facilities for ring and ring based web applications.
https://funcool.github.io/buddy-auth/latest/
Apache License 2.0
293 stars 68 forks source link

http-basic doc need amending #76

Open krisleech opened 6 years ago

krisleech commented 6 years ago

In the http-basic section it says to add (wrap-authentication), but it seems that (wrap-authorization) middleware is also needed.

Without this middleware no 'basic auth' dialog is shown to enter the username/password.

This caught me out because it didn't even occur to me that I needed to add "authorization" to do "authentication".

Thanks!

terop commented 6 years ago

I created a PR to fix this issue: https://github.com/funcool/buddy-auth/pull/81