search

funcool / clojure.jdbc

JDBC library for Clojure
http://funcool.github.io/clojure.jdbc/latest/
Apache License 2.0
105 stars 26 forks source link

Which version of hikari-cp should be used with clojure.jdbc? #21

Closed zeroDivisible closed 9 years ago

zeroDivisible commented 9 years ago

Hi,

Just wanted to ask - I've seen that docs are specifying to use 0.13.0 version of hikari-cp. The latest version of hikari-cp, advertised in README for it appears to be 1.1.1. Is it maybe the case that docs for clojure.jdbc should be updated or is there maybe a reason why previous version of hikari-cp is preferred?

Thanks! :)

niwinz commented 9 years ago

hi @zeroDivisible the documentation refers to hikari-cp concrete version as example. After release of clojure.jdbc documentation, hikari-cp has released new versions that are not reflected in clojure.jdbc documention. Nothing more.

You can use any version of hikari-cp. And in the next clojure.jdbc update, I will update the hikari-cp in the doc. Also, you can send a pr with a little fix and I gladly accept it ;)

zeroDivisible commented 9 years ago

@niwibe thanks! :D

I thought that this is the case, just wanted to confirm. I'm a total Clojure newbie, so just trying to play it safe :D

(I created PR, btw).

Thanks for this project:)