funcool / clojure.jdbc

JDBC library for Clojure
http://funcool.github.io/clojure.jdbc/latest/
Apache License 2.0
105 stars 26 forks source link

Lower Case Identifiers #7

Closed dubiousdavid closed 10 years ago

dubiousdavid commented 10 years ago

Can you please remove or create an overridable setting for the lower casing of identifiers? This behavior is unexpected and not necessarily desirable in all cases.

identifiers str/lower-case
niwinz commented 10 years ago

Hmm. Seems reasonable. I will change str/lower-case to identity as default value. However, currently you can override it using query and with-query functions.

niwinz commented 10 years ago

I have changed opinion, some database return identifiers as TITLECASE and is very ugly default behavior.

In any case, I have added one testcase for test override identifiers and it works as expected: https://github.com/niwibe/clj.jdbc/commit/fe5e0eb117188ed54d3742af52a38840a64bad9f