search

funcool / cuerdas

String manipulation library for Clojure(Script)
https://cljdoc.org/d/funcool/cuerdas/2020.03.26-3/
BSD 2-Clause "Simplified" License
304 stars 30 forks source link

numeric? returns vector of matched regex(es), not a boolean #41

Closed tuddman closed 8 years ago

tuddman commented 8 years ago

ref: https://github.com/funcool/cuerdas/blob/master/src/cuerdas/core.cljc#L215

convention of fnName? is to return true | false

docs say: Checks if a string contains only numeric characters.

numeric? instead returns vector of regex matches.

also, doesn't currently handle commas , or currencies, e.g. $

niwinz commented 8 years ago

Thanks! I will fix it ASAP. (right now i'm not available because of my weeding days).

niwinz commented 8 years ago

Fixed in 1.0.2