funcool / cuerdas

String manipulation library for Clojure(Script)
https://cljdoc.org/d/funcool/cuerdas/2020.03.26-3/
BSD 2-Clause "Simplified" License
304 stars 30 forks source link

Fix tests doc & replace-with warning #76

Closed bfontaine closed 4 years ago

bfontaine commented 4 years ago

The tests doc is outdated; I think I found the commands (tell me if those aren’t correct) and fixed the doc (fixes #75).

Also, there is a warning in cljs because str/replace-with is private. You can reproduce it on the latest master:

$ rm -rf out ; clj -A:dev ./tools.clj test-cljs 2>&1 | grep WARNING
WARNING: var: clojure.string/replace-with is not public at line 327 src/cuerdas/core.cljc

I fixed it as well (fixes #69).

bfontaine commented 4 years ago

The CI build error is the same as the one on master: https://travis-ci.org/funcool/cuerdas/jobs/611774731