search

functime-org / functime

Time-series machine learning at scale. Built with Polars for embarrassingly parallel feature extraction and forecasts on panel data.
https://docs.functime.ai
Apache License 2.0
1.02k stars 55 forks source link

Update pre-commit hooks: formatting with ruff, format pyproject.toml #108

Closed baggiponte closed 11 months ago

baggiponte commented 11 months ago

Configure ruff format and format the whole codebase.

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
functime-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2023 10:40am
baggiponte commented 11 months ago

Ciao @topher-lo, I just merged main in this branch. This is technically ready for review and should be fine. However, there are two more pre-commit hooks I'd like to add, if you agree.

  1. To avoid incurring in another issue like #110, we should add pre-commit check-added-large-files and potentially scope it to the data/ dir alone. This commit ignores by default git lfs data but will prevent someone who hasn't configured git lfs to upload a dataset by mistake.
  2. Locally ruff finds issues in the benchmarking notebook. If I fix the error, the notebook metadata changes and versioning those is a PITA. Do we need to version the contents of notebooks too? Otherwise I have the solution: nbstripout's pre-commit hook. If you agree I can add that to the pre-commit hook list.

Also