search

functime-org / functime

Time-series machine learning at scale. Built with Polars for embarrassingly parallel feature extraction and forecasts on panel data.
https://docs.functime.ai
Apache License 2.0
971 stars 52 forks source link

fix: Correct subplot positioning in plot_forecasts #180

Closed miroslaavi closed 4 months ago

miroslaavi commented 4 months ago

Fixes #179

What does this implement/fix? Explain your changes.

Plotting loop was referring to all unique entities instead of the sampled entities to be plotted. Also, adjusted the subplot position calculation to correctly handle an arbitrary number of series and columns. This change ensures that the grid layout of subplots is dynamically adjusted to accommodate the specified number of series, thus avoiding IndexError and incorrect subplot arrangements.

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
functime-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2024 10:14am
miroslaavi commented 4 months ago

This fixes the plotting module only partly, in the #181 it implements the fix for all three plotting functions having the same problem.