fix(206): Fix `ValueError` in `cwt_coefficients` - Githubissues

functime-org / functime

Time-series machine learning at scale. Built with Polars for embarrassingly parallel feature extraction and forecasts on panel data.

https://docs.functime.ai

Apache License 2.0

1.02k stars 55 forks source link

fix(206): Fix `ValueError` in `cwt_coefficients` #208

Closed khrapovs closed 5 months ago

khrapovs commented 5 months ago

Reference Issues/PRs

Closes #206

What does this implement/fix? Explain your changes.

cwt_coefficients does not throw ValueError anymore.
Now there is a minimal unit test for cwt_coefficients.

Any other comments?

I am not 100% sure in the fix myself. I have compared with https://github.com/scipy/scipy/blob/v1.13.0/scipy/signal/_wavelets.py#L543 and with https://tsfresh.readthedocs.io/en/latest/_modules/tsfresh/feature_extraction/feature_calculators.html#cwt_coefficients. But I do not have time to validate the math with the code. I will need a very thorough review.

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
functime-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 28, 2024 7:10am