search

functime-org / functime

Time-series machine learning at scale. Built with Polars for embarrassingly parallel feature extraction and forecasts on panel data.
https://docs.functime.ai
Apache License 2.0
970 stars 52 forks source link

fix: numpy precision #226

Open jhug12 opened 3 weeks ago

jhug12 commented 3 weeks ago

Fixes #225

Summary

Changes precision from float32 to float64 for conversion from polars DataFrame to numpy ndarray

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
functime-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 10:43am
baggiponte commented 3 weeks ago

Ciao @jhug12, sorry for being late and thanks for the great PR.

I merged a few things in the codebase: would you mind rebasing your PR?

Also: I see you committed other fixes and improvements (thanks once more 🤗) but I am not sure whether they relate to this PR. I can help you with putting some changes in other pull requests, as they will be easier to review.

(I was actually thinking whether we should just map the datatypes that come in and when we perform the conversion just respect those, and raise a warning if they're not F64)