search

functime-org / functime

Time-series machine learning at scale. Built with Polars for embarrassingly parallel feature extraction and forecasts on panel data.
https://docs.functime.ai
Apache License 2.0
970 stars 52 forks source link

fix: Updated join key in transform_new function in scale transformer #228

Open jhug12 opened 3 weeks ago

jhug12 commented 3 weeks ago

Fixes #227

What does this implement/fix? Explain your changes.

This pull request resolves an issue in the transform_new function of the scale transformer module, where an error occurred during execution due to a mismatch in index columns during a join operation. Previously, the function attempted to join the X DataFrame with the _mean DataFrame on index columns ('time' and 'entity'), but _mean contained only the 'entity' column. The fix was implemented by adjusting the join keys to ensure they align correctly across both DataFrames, thus eliminating the key mismatch error.

In addition to fixing the bug, this pull request updates the transform_new function to match the format of the transform and invert functions.

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
functime-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 1:08pm
baggiponte commented 3 weeks ago

Ciao @jhug12! Thanks for the contribution. Will review asap.

baggiponte commented 3 weeks ago

Ciao @jhug12, thanks again for the amazing work and spotting this bug. I have a fairly similar request like with your other PR: would you mind only keeping the commits related to the issue you raised? It'd be easier to review. Unfortunately that's a part of the codebase I am yet to become familiar with.