Closed abstractqqq closed 10 months ago
@topher-lo How close are you to finishing FFT and feature bundles? Do you need some help?
FFT is done. Feature bundles haven't started. If you have ideas for the latter, please take it on 🙏. I can help with docs
Closing this since we are mostly done.
The untested features that no one knows how to check the validity should be decorated with UseAtOwnRisk decorator I introduced in this branch: https://github.com/neocortexdb/functime/tree/feat/decorator_loggin_infra .
First, thank you everybody for contributing to the rewrite.
We are planning to make this project more public, which means we need to make sure that the quality is good. For this round of review, we want to focus on the following 3 items (ranked in terms of importance):
[x] [99%] Correctness. Correctness with respect to implementation, to feature definition, and the final numerical result should make sense. There are a few I haven't reviewed or I don't know if anybody has reviewed: cwt_coefficients, autoregressive_coefficients, augmented_dickey_fuller, and the newly added fft_coefficients.. Please comment if you think there are others we need to review.
[x] [99%] Tests. Building out more tests for all the features. Thank you @MathieuCayssol for building out more tests.
[x] Delayed FFT features. Now that fft_coefficients is implemented, we can start using it?
Ongoing, Performance. For some methods, there might be short cuts in eager mode, or vice versa. For methods (eager) that use NumPy under the hood, can we do better? Is there redundant computation? More efficient methods?