search

functional-koans / clojure-koans

A set of exercises for learning Clojure
3.74k stars 2.14k forks source link

1.10 error messages break the koans #136

Closed rnadler closed 5 years ago

rnadler commented 5 years ago

1.8.0/1.9.0:

Now meditate upon 08_conditionals.clj
---------------------
Assertion failed!
clojure.lang.ExceptionInfo: You will face many decisions
(= __ (if (false? (= 4 5)) :a :b)) {:line 13}, compiling:(/home/bob/Projects/clojure-koans/src/koans/08_conditionals.clj:11:1)

1.10.0:

Now meditate upon 08_conditionals.clj
---------------------
Assertion failed!
Syntax error compiling at (/home/bob/Projects/clojure-koans/src/koans/08_conditionals.clj:11:1).

As you can see, the 1.10 error message no longer allows you to determine what to fix.

trptcolin commented 5 years ago

Thanks for the report! I'll dig into it.

Out of curiosity, in order to get these different versions, are you manually updating the project.clj file in this clojure-koans project itself? Or is something else going on? (and if so, can you elaborate on what you're running to make this happen?) I'm assuming for the time being that this is something that'll bite us eventually when the default version gets bumped to 1.10.0, but does not yet (?) affect normal usage of the koans.

rnadler commented 5 years ago

Yes, I manually updated project.clj to switch versions. No other funny business going on that I know of!

trptcolin commented 5 years ago

I reproduced locally and believe this is fixed on master - thanks for the report!