functional-koans / clojure-koans

A set of exercises for learning Clojure
3.74k stars 2.14k forks source link

String koan #97

Closed FayeAlephNil closed 9 years ago

FayeAlephNil commented 9 years ago

Covers

Thanks for creating this tool btw, really helped me refresh on clojure after having not used it for a while

trptcolin commented 9 years ago

Hey, thanks a bunch for tackling this! I'm sorry it's taking me so long to review it. Work, parenting, excuses, etc.

Just 2 requests:

The file renames will make it tricky for anyone to merge in the latest changes. Not sure how common that use case is, but it's a problem that we have in general w/ this ordering scheme & adding koans in the middle. I'm fine leaving this re-ordering in place but if you have ideas on a less invasive ordering scheme for the future, I'd love to hear it!

Upgrading the Clojure version isn't related to the main goal of this PR, but I agree it's a good idea - :+1:

Thanks again, and sorry for the delay!

FayeAlephNil commented 9 years ago

That should fix those small problems. As far as the file renames I don't have a good solution, you'd have to fix that in the koan lein plugin with some system, and I don't have any ideas

trptcolin commented 9 years ago

Awesome, thanks!