search

functional-php / fantasy-land

Specification for interoperability of common algebraic structures in PHP
BSD 3-Clause "New" or "Revised" License
34 stars 10 forks source link

Fixes the autoload warnings #18

Closed mickprev closed 3 years ago

mickprev commented 3 years ago

This PR : 

Class FunctionalPHP\FantasyLand\Helpful\Tests\StringMonoid located in ./vendor/functional-php/fantasy-land/src/FantasyLand/Helpful/Tests/StringMonoidLawsTest.php does not comply with psr-4 autoloading standard. Skipping.
Class FunctionalPHP\FantasyLand\Helpful\Tests\NotAStringMonoid located in ./vendor/functional-php/fantasy-land/src/FantasyLand/Helpful/Tests/StringMonoidLawsTest.php does not comply with psr-4 autoloading standard. Skipping.
Class FunctionalPHP\FantasyLand\Helpful\Tests\MonoidLawsTest located in ./vendor/functional-php/fantasy-land/src/FantasyLand/Helpful/Tests/StringMonoidLawsTest.php does not comply with psr-4 autoloading standard. Skipping.
mickprev commented 3 years ago

Ping @widmogrod @krtek4

widmogrod commented 3 years ago

@mickprev could you re-push changes to this pull-request? I see that travis had issues and didn't cach this Pull Request.

mickprev commented 3 years ago

@widmogrod I just re-pushed :)

mickprev commented 3 years ago

One of the builds failed but I don't feel that my code is the cause :s

@widmogrod An idea?

widmogrod commented 3 years ago

Looks like maybe you will need to run composer fix, or that is something to do with cs-fixer

This is error message that we got from travis:

> php-cs-fixer fix --verbose --diff --dry-run --allow-risky=yes
359
360 In ToolInfo.php line 50:
361                         
362  [ErrorException]       
363  Undefined index: name  
364                         
365
366 Exception trace:
367  {closure}() at /home/travis/build/functional-php/fantasy-land/vendor/friendsofphp/php-cs-fixer/src/ToolInfo.php:50
368  PhpCsFixer\ToolInfo->getComposerInstallationDetails() at /home/travis/build/functional-php/fantasy-land/vendor/friendsofphp/php-cs-fixer/src/Console/WarningsDetector.php:49
369  PhpCsFixer\Console\WarningsDetector->detectOldVendor() at /home/travis/build/functional-php/fantasy-land/vendor/friendsofphp/php-cs-fixer/src/Console/Application.php:75
370  PhpCsFixer\Console\Application->doRun() at /home/travis/build/functional-php/fantasy-land/vendor/symfony/console/Application.php:143
371  Symfony\Component\Console\Application->run() at /home/travis/build/functional-php/fantasy-land/vendor/friendsofphp/php-cs-fixer/php-cs-fixer:58
372
373. Script php-cs-fixer fix --verbose --diff --dry-run --allow-risky=yes handling the check-code event returned with error code 1
mickprev commented 3 years ago

The problem was already on the main branch. You had a dependency in the composer.lock file which did not declare a name in its composer.json file. Certainly that must have been a relic because this package: gecko-packages/gecko-php-unit, does not seem to be used.

I took the opportunity to no longer track the composer.lock file in GIT because it is not necessary for this library (see https://getcomposer.org/doc/02-libraries.md#lock-file). It suits you?

It would also be interesting to update PHPUnit later because version 5 is starting to be a bit dated :)

mickprev commented 3 years ago

Hi @widmogrod,

Can we merge this PR? :)

widmogrod commented 3 years ago

@mickprev thank you for contribution! I released version 1.0.1, soon it should be propagated and ready to download via composer