Closed widmogrod closed 6 years ago
Seems all good to me :)
It seems that the declare(strict_types=1);
is incompatible with PHP5.6 which is kind of a shame. It still representes roughly 30% of the user base.
I think we can keep it at PHP7. let me know what you think :)
@krtek4 very good, and hard question.
Doing it now is also an option, there is no performance gain by using declare(strict_types=1);
, so it can be easily removed. Only harm would be regarding Functor
which depends on return type : self
We could make assumption that IF there is an need from the community to support older version of PHP we should do it.
Doing it now it's little bit like "premature optimisation" build on assumption that we will loose user because we don't support PHP 5.6.
Ok, seems right :)
Address issue https://github.com/functional-php/fantasy-land/issues/1
Also adds integration with travis https://github.com/functional-php/fantasy-land/issues/5