Bug in Local Frechet Regression under Cholesky metric

functionaldata / tFrechet

Test version of frechet

Other

10 stars 5 forks source link

Bug in Local Frechet Regression under Cholesky metric #3

Open dtucke5 opened 3 years ago

dtucke5 commented 3 years ago

Hello!

I found a bug in your code while trying to use it myself. Take a look at line 86 in the following file: tFrechet/R/LFRCovCholesky.R

The function stops working IF you have at least 2 predictors, not if you DONT have at least 2 predictors.

I fixed it locally for myself, but thought you might want to know.

yqgchen commented 3 years ago

Hello,

Thank you for your comment. However, it seems to us that Line 86 does what we intend---stop the program if p is greater than 2. Please let us know if you have further concerns.

Best, Yaqing