Use OpenZeppelin's ReentrancyGuard and add events

functionalfoundry / ethereum-htlc

HTLC for doing cross-chain atomic swaps

MIT License

7 stars 2 forks source link

Use OpenZeppelin's ReentrancyGuard and add events #4

Closed Jannis closed 7 years ago

Jannis commented 7 years ago

This PR addresses #2 and improves #3 by using a community-audited and -tested contract for guarding against reentrancy (ReentrancyGuard from OpenZeppelin) so we don't need to roll our own logic.

yanivtal commented 7 years ago

It appears that you're right that transfer() doesn't need to be guarded but let's go ahead and merge this for now. LGTM 👍