Open gitaaron opened 2 years ago
@gitaaron does it mean the message needs to be changed to something like loading or there is a root error here?
I think changing it to something like 'loading' is good no root error in the protocol maybe just a fix in the sample? @faroud correct me if I'm wrong
On Tue., Jun. 7, 2022, 9:58 p.m. ehsan shariati, @.***> wrote:
@gitaaron https://github.com/gitaaron does it mean the message needs to be changed to something like loading or there is a root error here?
— Reply to this email directly, view it on GitHub https://github.com/functionland/fula/issues/211#issuecomment-1149365416, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAFDZ56KLP4JMABRL76JK3VN7425ANCNFSM5YEHGNIQ . You are receiving this because you were mentioned.Message ID: @.***>
I think changing it to something like 'loading' is good no root error in the protocol maybe just a fix in the sample? @Faroud correct me if I'm wrong
You are right the code in src/components/Gallery.jsx
look if the photos state size is 0 show the no photos.
I think gallery should not loaded when we are on loading.
I think changing it to something like 'loading' is good no root error in the protocol maybe just a fix in the sample? @Faroud correct me if I'm wrong.
your are right,
If I connect the sample gallery to a Box and throttle the connection. After logging in I see the 'no photos' message even if I have already added photos to the gallery. Once the collection loads then the message disappears and the photos are displayed.