functionland / fx-fotos

"Fx Fotos" is an opensource gallery app in react native with the same smoothness and features of Google Photos and Apple Photos. It is backend gnostic and connects to decentralized backends like "box", "Dfinity", "Filecoin" and "Crust".
https://t.me/functionland
MIT License
674 stars 74 forks source link

story highlights #90

Open gitaaron opened 2 years ago

gitaaron commented 2 years ago

A horizontal list thumbnails/titles at the top of the 'photos' section for special events/timelines. Tapping on the thumbnail should bring up the story. The story is a slideshow that cycles through the list of photos.

--- Want to back this issue? **[Post a bounty on it!](https://app.bountysource.com/issues/107536203-story-highlights?utm_campaign=plugin&utm_content=tracker%2F206746002&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://app.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F206746002&utm_medium=issues&utm_source=github).
emadbaqeri commented 2 years ago

Hey @ghorbani-m, In which pattern we are categorizing the images on the slide shows? Can you please elaborate and describe this features details? I would like to work on this issue/feature.

emadbaqeri commented 2 years ago

@gitaaron , @ehsan6sha , @ghorbani-m I have tried this feature on my phone but this feature was missing from mine. But there's something like this on iPhone photos app that picks the images randomly and shows them as featured photos. The thing is I have no idea how to pick specific pictures and categorize them. @ghorbani-m do you still have the old version of the app, if you do so please share that with me. I need to take look at that. Any ideas on this would be appreciated ;)

ghorbani-m commented 2 years ago

Hey @ghorbani-m, In which pattern we are categorizing the images on the slide shows? Can you please elaborate and describe this features details? I would like to work on this issue/feature.

@emadbaqeri , Thanks for contributing, As I know Google photos use some AI mechanism to collect some of the images as a highlight for the clients, But for now, we can highlight the images based on the creation date, like these:

emadbaqeri commented 2 years ago

Hey @ghorbani-m, In which pattern we are categorizing the images on the slide shows? Can you please elaborate and describe this features details? I would like to work on this issue/feature.

@emadbaqeri , Thanks for contributing, As I know Google photos uses some AI mechanism to collect some of the images as a highlight for the clients, But for now, we can highlight the images based on the creation date, like these:

  • last week
  • last month
  • last 3 moth
  • last 6 month
  • last 12 month
  • ...

Thanks for your response, will be working on this part

ghorbani-m commented 2 years ago

@emadbaqeri FYI: There is a function (categorizeAssets) in the asset-service that categorized the images and prepare them for RecycleListLiew, This is where you can add your algorithm to create the stories.

emadbaqeri commented 2 years ago

@ghorbani-m ohh I was thinking 🤔 about how to categorize the images. Thanks for that

gitaaron commented 2 years ago

My two cents - I don't think the algo matters that much right now. Instead I'd focus on the interface trying to think about what might come in the future. I'd also be concerned about running the categorization process while the main UI thread is in the foreground. Even if it is running under its own thread (ie/ not blocking the UI) while the app is running in the foreground then I'd be careful that the app responsiveness is not degraded. Ideally it could run as a batch process in the background (ie/ UI is not in foreground) while the phone is plugged in.

Perhaps splitting it like this?

https://www.figma.com/file/nL3pPlzYkysK5NJ4XpD8pN/Untitled?node-id=0%3A1

That way the batch process might come from the Box in the future.

For the categorization algo - I think you guys have it right in clustering based on time. Perhaps you could also do proximity in the future?

ghorbani-m commented 2 years ago

@gitaaron Thanks for the comment, you are right, for highlighting the images we need to have some AI algo that could be done on the BOX, for now, we are preparing the UI to show the highlights on the top of listview, so we need a simple algo to collect some images as a highlight. later we can feed UI's data with a smart highlight collection that has been prepared with AI.

gitaaron commented 2 years ago

sounds good @ghorbani-m I had a feeling you were already taking these considerations in mind