search

fundacaocerti / mobsf-action

GitHub Actions for MobSF
GNU General Public License v3.0
25 stars 23 forks source link

Update REAME to solve permissions issues #16

Open inm-certi opened 2 years ago

inm-certi commented 2 years ago

Include extra steps do fix MobSF Docker permissions before and cleanup it later.

Resolve #14 Resolve #15

@jpeiffer, @leinardi, Can you review this PR?

jpeiffer commented 2 years ago

I think the only thing I would add is that this will only work on GitHub hosted runners. If you are using a self hosted runner, the paths will be different.

jpeiffer commented 2 years ago

Oh, the process for iOS is different too because this can't work on macos and needs to run on Linux. I have a private example that I'll "de-sensitize" later tonight and share with you so you can add that in too.

inm-certi commented 2 years ago

I'm thinking... probably a better solution is to fix the Dockerfile to run as root instead of 9091.

inm-certi commented 2 years ago

In the meantime I created another PR, that should fix the issue by using an older version of MobSF. https://github.com/fundacaocerti/mobsf-action/pull/17

In fact it should have a locked version since the beginning.

jpeiffer commented 2 years ago

I honestly don't know why they chose to make the Docker run as non-root. It definitely makes things harder when working with actions.

mutairibassam commented 2 years ago

@inm-certi there an issue with step Flutter Install Dependencies and @latest in readme

I copied readme file and run as-is and faced the below error

Error: Invalid run/uses syntax for job:Build step:Flutter Install Dependencies

When I removed the - before run keyword, it worked. I believe the - is not valid since you are using name keyword.

For some reasons @latest is not working. I had to point to a specific version, in my case I pointed to v1.7.2 and it worked.

KlausNie commented 2 years ago

Is this issue related to this error docker: Error response from daemon: unable to find user mobsf: no matching entries in passwd file. ? I get this in the Run MobSF Analysis step and I'm running it on a self-hosted runner