search

fundevogel / fundevogel.de

Source code for the Fundevogel website.
https://fundevogel.de
GNU General Public License v3.0
2 stars 1 forks source link

WebP support #16

Closed daybugging closed 4 years ago

daybugging commented 6 years ago

Hey there, since you are very into performance, why not go for WebP support?

S1SYPHOS commented 6 years ago

That's a good idea, had thought about it before. Feel free to open a PR on how to integrate WebP generation into the existing workflow - didn't have much time back in the days to look for / write a plugin for gulp / gulp-imagemin

// Edit: https://github.com/imagemin/imagemin-webp

S1SYPHOS commented 6 years ago

Update: Seems like I have to write an extension if I want WebP support for images uploaded from Kirby's panel, this library might provide a good starting point: https://github.com/rosell-dk/webp-convert

Also, after converting images to .webp, adding this .htaccess directive will replace them if the format is supported by the browser: https://github.com/vincentorback/WebP-images-with-htaccess

S1SYPHOS commented 6 years ago

kirby-webp is out now, plus I added WebP generation to the workflow with this commit. As soon as it lands in this repository as submodule, this will be closed.

Thanks again for the suggestion :+1:

S1SYPHOS commented 4 years ago

For Kirby v3, I might use @hashandsalt's WebP plugin, be sure to check it out :koala:

.. or maybe I'll come up with my own solution :dancer: Cheers!

S1SYPHOS commented 4 years ago

This has been implemented, thanks for your patience.