HTTP/2 doesnt care for requests, why should you

fundevogel / fundevogel.de

Source code for the Fundevogel website.

https://fundevogel.de

GNU General Public License v3.0

2 stars 1 forks source link

HTTP/2 doesnt care for requests, why should you #73

Closed replicant64 closed 4 years ago

replicant64 commented 4 years ago

Requests shouldn't matter with HTTP/2, so easier with single items - might not get cached all, BUT tell me if wrong: CSP doesn't like icons.svg at least on FF, no?

Buggy shit if ask me, go CHROME! 👍

S1SYPHOS commented 4 years ago

See, it's not about making requests, since HTTP/2 doesn't limit us there, as you correctly stated. This is rather an issue of caching SVG images - inlining them = no cache.

Since I'm working on a similar approach, I'll have to turn this one down. Next time, let's talk first before opening a PR with (somewhat) breaking changes, alright? :fox_face:

Thanks for your effort!

S1SYPHOS commented 4 years ago

I decided to close this PR since our critical CSS workflow goes live within the next days. If you'd like, you're more than welcome to test it 🐺