search

fundsaccess / angular-iban

IBAN directives and pipes for Angular
MIT License
17 stars 7 forks source link

Support Angular 11 (with npm 7.11) #17

Closed suitablecode closed 3 years ago

suitablecode commented 3 years ago

When using angular-iban 3.0.0 in an Angular 11 (with npm 7.11) application there are dependency conflicts when using npm i

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: xxx-frontend@0.0.0
npm ERR! Found: @angular/common@11.1.2
npm ERR! node_modules/@angular/common
npm ERR!   @angular/common@"11.1.2" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"^10.x" from angular-iban@3.0.0
npm ERR! node_modules/angular-iban
npm ERR!   angular-iban@"^3.0.0" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

It would be nice to have an updated release which supports Angular 11.

I will make a PR to have this updated.

suitablecode commented 3 years ago

see https://github.com/fundsaccess/angular-iban/pull/18

kimljj commented 3 years ago

@suitablecode , your PR was merged and a new version was published on npm https://www.npmjs.com/package/angular-iban Thanks again for your contribution!