search

fundsaccess / ng-chiptan

angularjs component to render chiptan flicker code
MIT License
1 stars 1 forks source link

Fix binding for colors #5

Open WuglyakBolgoink opened 4 years ago

WuglyakBolgoink commented 4 years ago

Nobody change colors in realtime. In this case it will be better to replace bindings for colors with '@'

also:

bindings: {
        code: '<',
        width: '<',
        height: '<',
        bgColor: '@',
        barColor: '@',
},

https://github.com/fundsaccess/ng-chiptan/blob/7c7b8da6007713abd4e39ee631c531de1e044b6e/src/lib/ng-chiptan.js#L12-L13

WuglyakBolgoink commented 4 years ago

fixed in https://github.com/fundsaccess/ng-chiptan/pull/6