search

fungible-systems / micro-stacks

Tiny libraries for building the next generation of Stacks apps.
https://micro-stacks.dev
MIT License
82 stars 15 forks source link

fix: correct package imports & reduce code example #141

Closed jjenzz closed 2 years ago

jjenzz commented 2 years ago

i updated the wallet connect code example here because initially i thought the label wouldn't be reactive given it is declared in the component scope (instead of the return) but TIL that solidjs will make anything wrapped in JSX reactive even if it is declared outside of the return....

so const foo = <>{signalValue()}</> would work but const foo = signalValue() wouldn't 🙈.

while clever, it seemed a bit confusing so i just simplified things a bit.

changeset-bot[bot] commented 2 years ago

⚠️ No Changeset found

Latest commit: d550291eb1bf08f29c1fc5fa0f77ee192cc05dd4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
micro-stacks-docs ✅ Ready (Inspect) Visit Preview Jul 28, 2022 at 4:09PM (UTC)