search

fungible-systems / micro-stacks

Tiny libraries for building the next generation of Stacks apps.
https://micro-stacks.dev
MIT License
82 stars 15 forks source link

feat: added versioned contract support #186

Closed 52 closed 6 months ago

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: 1117218541c55cc457c78bf089da9aa67b8b1c8a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
micro-stacks-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2023 11:41pm
52 commented 1 year ago

This is looking good to me. Please add a changeset -> https://github.com/changesets/changesets/blob/main/docs/intro-to-using-changesets.md

Sure, will do.

additionally, were you able to test it with a wallet?

Yes & no - I tested the literal use of makeContractDeploy in an example app, which works as expected (defaults to Clarinet2, but can be overwritten to Clarinet1).

Ideally, we'd be able to set this in react's openContractDeploy, but haven't tackled this yet so any pointers are greatly appreciated. 🙏

aulneau commented 1 year ago

it should be the case that if you add the types here: https://github.com/mxnnn/micro-stacks/blob/feat/versioned-contracts/packages/core/src/connect/tx/types.ts#L43

it will just work ™️ as all the params are automatically passed. I'd suggest making it clarity2 by default, what do you think?

52 commented 1 year ago

it should be the case that if you add the types here: https://github.com/mxnnn/micro-stacks/blob/feat/versioned-contracts/packages/core/src/connect/tx/types.ts#L43 it will just work ™️ as all the params are automatically passed.

Hmm, weird - I did try that yesterday, but in my case, it didn't work ™️ 🤣 Gotta take a deeper dive into the package, will try to find some time on friday. 👍

I'd suggest making it clarity2 by default, what do you think?

Sounds good, lets do it 👍