Closed billyeh closed 10 years ago
Thanks for helping me test the code out. For the first bug, I missed the fact that we should change the default regex depending on doctype, so I've added that in the latest commit. As for the other bug, here's what I did:
python parse.py -d application -x ipa130124.xml
But it runs fine on mine. So I'd like to be able to help, but it's hard to me to tell what's wrong without being able to reproduce it. Maybe there's some of the latest code I don't have that involves application.granted.
Edit: Pulled an update from funginstitute's master branch and re-ran with the same results, so I don't think anything in there can be causing it.
Edit 2: I got a fresh copy of the repository, and the error does occur on this one. Interesting. I'll look into it.
All right, after finding the same bug in a brand-new cloned repo from the fork, I found that running make spotless
fixes it. Not sure why, but maybe you could try that out? In the case that it fixes the problem, I can't really see any candidates for messing the code up besides maybe accidentally-committed .pyc, .db, or .sqlite3 files.
Thanks for your work, Bill! Running make spotless
fixes the error for me as well.
I'm still running into a problem if I have both IPG and IPA files in the same directory. If I run python parse.py -d application
, it still attempts to parse the IPG file.
Wait no nevermind no it doesn't. Sorry.
I'm going to wait until the database is populated and the bridge server isn't as busy, then I'll work to merge this pull request. I'll let you know of any more bugs I come across, but so far everything looks great!
Github is telling me I can't automatically merge this pull request. Can you fetch the changes from upstream to your local repository, make all the merges, and then re-issue this pull request?
Sure. I can do that pretty soon.
I'm having trouble getting the script to parse applications. The following incantation of
parse.py
seems to start parsing the grant file I have in my directory:python parse.py -d application
Also, when I specify the file using
python parse.py -d application -x ipa130124.xml
, I get the following error:Can you look into these?
Thanks!