PDB handling improvements

fungos / cr

cr.h: A Simple C Hot Reload Header-only Library

https://fungos.github.io/cr-simple-c-hot-reload/

MIT License

1.56k stars 104 forks source link

PDB handling improvements #26

Closed rokups closed 5 years ago

rokups commented 5 years ago

When patching PDB path in library file - use only file name and not the full path.

Benefit of this is that (99.99% of the time) we no longer need to trim plugin name to ensure that we have enough space for plugin version number.

Also retrieval of original PDB path was cleaned up.

Edit: Ah yeah CI fails because this depends on https://github.com/fungos/cr/pull/25/commits/230f022229bab8ff3df4b26653b7cbb2310c0676. Once (if) that is merged i will rebase this PR.

fungos commented 5 years ago

Can you fix this compilation warning? Looks good otherwise.

fungos commented 5 years ago

I tried to use the merge conflict feature from github to merge this PR, but I seems it didn't go so well. If you can fix this and force push again, it will be great, thank you!

fungos commented 5 years ago

Thanks!