fungos / cr

cr.h: A Simple C Hot Reload Header-only Library
https://fungos.github.io/cr-simple-c-hot-reload/
MIT License
1.54k stars 101 forks source link

fix initial dll lock in visual studio 2017 #33

Closed datgame closed 5 years ago

datgame commented 5 years ago

same problem as https://github.com/fungos/cr/issues/12 the original pdb is locked for some reason if the pdb-string is garbled, as it was without a terminating zero. original path: "d:\dev\netphys\_build_win_d\game\game.pdb" patched: "gam0.pdbetphys\_build_win_d\game\game.pdb" after bugfix: "gam0.pdb\0etphys\_build_win_d\game\game.pdb"

sorry about the trailing white space trimming, i got that on autosave in my editor. not sure how to ignore it in diffs on github.

looks like this actually was working before, but broke in: https://github.com/fungos/cr/commit/d1d02ea4f9e770acc4f176b45a9f1cc3e37c46ea

fungos commented 5 years ago

Thanks for contributing. I didn't had the time to look at it in detail. I'll check it soon.

fungos commented 5 years ago

Thank you!