search

fungos / cr

cr.h: A Simple C Hot Reload Header-only Library
https://fungos.github.io/cr-simple-c-hot-reload/
MIT License
1.57k stars 103 forks source link

clang compile warnings #47

Open datgame opened 5 years ago

datgame commented 5 years ago 
#if CR_EXPAND(CR_HOST) == 1337
    ^
cr.h:526:22: note: expanded from macro 'CR_EXPAND'
#define CR_EXPAND(x) CR_DO_EXPAND(x)
                     ^
cr.h:525:25: note: expanded from macro 'CR_DO_EXPAND'
#define CR_DO_EXPAND(x) x##1337
                        ^
<scratch space>:560:1: note: expanded from here
CR_UNSAFE1337

when doing

#define CR_HOST CR_UNSAFE
#include "cr.h"

i think also that CR_STATE is not working for me, (never tried before), because ASAN (clang++ -fsanitize=address) complains upon reload. i tried adding these to the globals in stb_image.h

#include "cr.h"
static const char CR_STATE *stbi__g_failure_reason;

but ASAN still complains. not sure if that's correct in this matter or not, but i think so.

not sure if these 2 are related or not. nor what to do about them

that was on linux.

trying to build the same on windows now, i get:

cr.h(455): warning C4109: unexpected identifier '_read'
stb_image.h(845): error C2341: '.state': segment must be defined using #pragma data_seg, code_seg or section prior to use
fungos commented 5 years ago

Tested the CR_STATE CR_UNSAFE here and no warning at all (gcc/clang, linux). I don't have a windows box to test, so I'll let this open and maybe someone can help fix.