search

fungover / haze

Key-Value database that talks RESP
MIT License
8 stars 9 forks source link

115 refactor main #206

Open cmatlak opened 9 months ago

robinalfengard commented 9 months ago

Build failed. According to report: "/home/runner/work/haze/haze/src/main/java/org/fungover/haze/Main.java:[133,20] the switch expression does not cover all possible input values" Maybe compare commands from Command class with cases in the switch?

Lucia560 commented 9 months ago

Is the switch missing the default case ? Also , in the workflow should the lines 30-39 be kept? maven compile and maven test .

ValentinaSukonina commented 9 months ago

There is a compilation problem due to the missing parts in the MainTest:

line 118-128 @Test @DisplayName("getInputList Should Return List With Correct Data Based On Index") This test is missing closing bracket "}".

line 130 This test is missing the starting line (@Test) (void callExecuteCommandWithIncrShouldIncreaseTheValueOfTheKeyBy1())

sonarcloud[bot] commented 5 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
25.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud