search

fungover / haze

Key-Value database that talks RESP
MIT License
8 stars 9 forks source link

#58 Release-config error #58

Closed MikaelEdwartz closed 1 year ago

MikaelEdwartz commented 1 year ago

from release-drafter, I believe our error message Screenshot 2023-02-08 at 13 43 43

might be caused because missing

Screenshot 2023-02-08 at 13 44 13

pull_request_target event

adding it might fix the problem

kappsegla commented 1 year ago

That's interesting because here the code is the same as ours?

MikaelEdwartz commented 1 year ago

That's interesting because here the code is the same as ours?

Yes the code is the same, but in the commented code it says "pull_request_target event is required for autolabeler to support PR's from forks, and the types is opened, reopened, and synchronize. Which our code doesn't include, and error message says that pull_request_target.reopened isnt a valid webhook.

Can the problem be caused by release_drafter trying to use it but since we don't have it in our yml file we get that it isn't a valid webhook?

kappsegla commented 1 year ago

@MikaelEdwartz after looking at some other projects it seems that this log message is printed always? But if someone of us are using PR from forks we might have to add more stuff to the config file. But is anyone doing that or are all of us pushing feature branches directly to this repo?